[webkit-reviews] review granted: [Bug 116689] clearLayoutOverflow should not be called before calling updateScrollInfoAfterLayout : [Attachment 204093] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Roger Fong <roger_fong at apple.com>'s
request for review:
Bug 116689: clearLayoutOverflow should not be called before calling
updateScrollInfoAfterLayout
https://bugs.webkit.org/show_bug.cgi?id=116689

Attachment 204093: Patch
https://bugs.webkit.org/attachment.cgi?id=204093&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=204093&action=review


> Source/WebCore/ChangeLog:3
> +	   clearLayoutOverflow should never be called before calling
layer()->updateScrollInfoAfterLayout().

Bug title should describe the symptom, not the structural problem in the code.

> Source/WebCore/ChangeLog:15
> +	   (WebCore::RenderBlock::layout): Only call clearLayoutOverflow here
if we're scrolling isn't being delayed.

extra word "we're" here

> Source/WebCore/ChangeLog:20
> +	   * rendering/RenderDeprecatedFlexibleBox.cpp: Should call
updateScrollInfoAfterLayout, not layer()->updateScrollInfoAfterLayout()

Why? Comment needs to say why, not what is changed. And a deeper level of why
than “should”.