[webkit-reviews] review granted: [Bug 117373] REGRESSION: ASSERT failures in stack walking code on FTL branch : [Attachment 204095] the patch.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Jun 8 13:29:15 PDT 2013


Oliver Hunt <oliver at apple.com> has granted Mark Lam <mark.lam at apple.com>'s
request for review:
Bug 117373: REGRESSION: ASSERT failures in stack walking code on FTL branch
https://bugs.webkit.org/show_bug.cgi?id=117373

Attachment 204095: the patch.
https://bugs.webkit.org/attachment.cgi?id=204095&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>
Can we have an enum type so distinguish whether an offset should be bytes or
instructions?

e.g. enum InstructionOffset {};  enum ByteOffset {}; ByteOffset
byteOffsetFromInstruction(unsigned i) { return i * sizeof Instruction } , etc


More information about the webkit-reviews mailing list