[webkit-reviews] review granted: [Bug 117344] [curl] Allow headers with empty value : [Attachment 204041] fixed patch

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Peter Gal
<galpeter at inf.u-szeged.hu>'s request for review:
Bug 117344: [curl] Allow headers with empty value
https://bugs.webkit.org/show_bug.cgi?id=117344

Attachment 204041: fixed patch
https://bugs.webkit.org/attachment.cgi?id=204041&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=204041&action=review


> Source/WebCore/ChangeLog:11
> +	   No new tests, alread covered by:
> +	  
http/tests/xmlhttprequest/xmlhttprequest-setrequestheader-no-value.html
> +	   http/tests/xmlhttprequest/post-blob-content-type-sync.html
> +

no updated results?

> Source/WebCore/platform/network/curl/ResourceHandleManager.cpp:758
> +		   // insert the ; to tell curl that this header has an empty
value

Nit: Use real sentences: "Insert" and punctuation mark at end.