[webkit-reviews] review granted: [Bug 117366] isContravenedByStructure is backwards : [Attachment 204075] Patch

[bugzilla-daemon at webkit.org]

Filip Pizlo <fpizlo at apple.com> has granted Mark Hahnenberg
<mhahnenberg at apple.com>'s request for review:
Bug 117366: isContravenedByStructure is backwards
https://bugs.webkit.org/show_bug.cgi?id=117366

Attachment 204075: Patch
https://bugs.webkit.org/attachment.cgi?id=204075&action=review

------- Additional Comments from Filip Pizlo <fpizlo at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=204075&action=review


> Source/JavaScriptCore/dfg/DFGArrayMode.h:366
>      bool isContravenedByStructure(Structure* structure)

Can we make it clearer that the thing that was proven was the structure?

What about having a method called:
structureWouldPassArrayModeFiltering(Structure*)

RS=me to make a change like that