[webkit-reviews] review requested: [Bug 115804] Avoid unnecessary data copies when loading subresources with DoNotBufferData option : [Attachment 204059] Updated patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 7 11:44:23 PDT 2013


Carlos Garcia Campos <cgarcia at igalia.com> has asked  for review:
Bug 115804: Avoid unnecessary data copies when loading subresources with
DoNotBufferData option
https://bugs.webkit.org/show_bug.cgi?id=115804

Attachment 204059: Updated patch
https://bugs.webkit.org/attachment.cgi?id=204059&action=review

------- Additional Comments from Carlos Garcia Campos <cgarcia at igalia.com>
Patch rebased and updated to address review comments. In the end I got rid of
the allDataReceived boolean parameter in CachedImage by refactoring the code a
bit, since now we have different methods for incremental data chunks and
finishLoading when all data has been received (and considering the multipart
content case), I think it makes the code a bit easier to read.


More information about the webkit-reviews mailing list