[webkit-reviews] review granted: [Bug 117327] 32-bit CallFrame::Location should use Instruction* for BytecodeLocation, not bytecodeOffset : [Attachment 203982] the patch.

[bugzilla-daemon at webkit.org]

Michael Saboff <msaboff at apple.com> has granted Mark Lam <mark.lam at apple.com>'s
request for review:
Bug 117327: 32-bit CallFrame::Location should use Instruction* for
BytecodeLocation, not bytecodeOffset
https://bugs.webkit.org/show_bug.cgi?id=117327

Attachment 203982: the patch.
https://bugs.webkit.org/attachment.cgi?id=203982&action=review

------- Additional Comments from Michael Saboff <msaboff at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=203982&action=review


r=me

> Source/JavaScriptCore/ChangeLog:7
> +

Some comments as to what you did.

> Source/JavaScriptCore/interpreter/CallFrame.h:138
> +		   BytecodeLocation = 0,
>		   CodeOriginIndex = (1 << 0),
>		   IsInlinedCode = (1 << 1),

I know some of this was from the earlier patch, but it may be less confusing if
these where just literal values, 0, 1 & 2.