[webkit-reviews] review granted: [Bug 115931] REGRESSION: Lines jump up and down while typing Chinese or Japanese : [Attachment 203991] Fixes the bug

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 115931: REGRESSION: Lines jump up and down while typing Chinese or Japanese
https://bugs.webkit.org/show_bug.cgi?id=115931

Attachment 203991: Fixes the bug
https://bugs.webkit.org/attachment.cgi?id=203991&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=203991&action=review


I hope creating and destroying these empty hash sets is inexpensive enough.

> Source/WebCore/platform/graphics/Font.cpp:325
> +    ASSERT(fallbackFonts);

This assertion is really unnecessary. The code that guarantees this is non-zero
is just a couple lines up from here.