[webkit-reviews] review denied: [Bug 117343] REGRESSION: r149001 made proximity test fail. : [Attachment 204035] Patch

[bugzilla-daemon at webkit.org]

Christophe Dumez <dchris at gmail.com> has denied Kihong Kwon
<kihong.kwon at samsung.com>'s request for review:
Bug 117343: REGRESSION: r149001 made proximity test fail.
https://bugs.webkit.org/show_bug.cgi?id=117343

Attachment 204035: Patch
https://bugs.webkit.org/attachment.cgi?id=204035&action=review

------- Additional Comments from Christophe Dumez <dchris at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=204035&action=review


Sorry this is not what I meant.

> LayoutTests/proximity/window-property.html:20
> +shouldBeFalse("window.propertyIsEnumerable('DeviceProximityEvent')");

This change is OK. However, the hasDeviceProximityEventProperty() function 10
lines above should be removed as well and it is likely not used anymore.

> LayoutTests/proximity/window-property.html:-34
> -shouldBeTrue("hasOnDeviceProximityProperty()");

This is unrelated and should stay.