[webkit-reviews] review granted: [Bug 117328] Completely initialise ChildProcess state on launch : [Attachment 203986] Patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Oliver Hunt <oliver at apple.com>'s
request for review:
Bug 117328: Completely initialise ChildProcess state on launch
https://bugs.webkit.org/show_bug.cgi?id=117328

Attachment 203986: Patch
https://bugs.webkit.org/attachment.cgi?id=203986&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=203986&action=review


> Source/WebKit2/ChangeLog:8
> +	   Don't rely on receiving a message from the UI process as part of our
initialisation

I don't think this make sense.

> Source/WebKit2/Shared/mac/ChildProcessMac.mm:151
> -    setProcessSuppressionEnabled(false);
> +    setProcessSuppressionEnabledInternal(false);

You should note why you are using the weird internal variant here.