[webkit-reviews] review granted: [Bug 117220] Allow for toggling fullscreen on <video> elements : [Attachment 203980] Patch

[bugzilla-daemon at webkit.org]

Jer Noble <jer.noble at apple.com> has granted Ruth Fong <ruthiecftg at gmail.com>'s
request for review:
Bug 117220: Allow for toggling fullscreen on <video> elements
https://bugs.webkit.org/show_bug.cgi?id=117220

Attachment 203980: Patch
https://bugs.webkit.org/attachment.cgi?id=203980&action=review

------- Additional Comments from Jer Noble <jer.noble at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=203980&action=review


> Source/WebCore/rendering/HitTestResult.cpp:421
> +    HTMLMediaElement* mediaElt = mediaElement();
> +    if (mediaElt && mediaElt->hasTagName(HTMLNames::videoTag)) {
> +	   HTMLVideoElement* videoElt =
static_cast<HTMLVideoElement*>(mediaElt);
> +	   if (mediaElt->supportsFullscreen()) {
> +	       UserGestureIndicator
indicator(DefinitelyProcessingNewUserGesture);
> +	       videoElt->toggleFullscreenState();
> +	   }

Re-picking Geoff's nit: "mediaElt" => "mediaElement", "videoElt" =>
"videoElement", and solve the name collision by calling "this->mediaElement()"

Apart from that, r=me.