[webkit-reviews] review granted: [Bug 93977] Implement testRunner.numberOfPendingGeolocationPermissionRequests() : [Attachment 203964] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Javier Fernandez
<jfernandez at igalia.com>'s request for review:
Bug 93977: Implement testRunner.numberOfPendingGeolocationPermissionRequests()
https://bugs.webkit.org/show_bug.cgi?id=93977

Attachment 203964: Patch
https://bugs.webkit.org/attachment.cgi?id=203964&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=203964&action=review


> Tools/WebKitTestRunner/TestInvocation.cpp:679
> +	   int number =
TestController::shared().numberOfPendingGeolocationPermissionRequests();
> +	   WKRetainPtr<WKTypeRef> result(AdoptWK, WKUInt64Create(number));
> +	   return result;

The right way to write this is:

    return
adoptWK(WKUInt64Create(TestController::shared().numberOfPendingGeolocationPermi
ssionRequests()));

No need for the local variables.