[webkit-reviews] review granted: [Bug 117209] CallFrame::trueCallFrame() should populate the bytecodeOffset when reifying Inlined frames : [Attachment 203930] the patch.

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Mark Lam <mark.lam at apple.com>'s
request for review:
Bug 117209: CallFrame::trueCallFrame() should populate the bytecodeOffset when
reifying Inlined frames
https://bugs.webkit.org/show_bug.cgi?id=117209

Attachment 203930: the patch.
https://bugs.webkit.org/attachment.cgi?id=203930&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=203930&action=review


r=me

> Source/JavaScriptCore/dfg/DFGJITCompiler.h:317
> +	   unsigned locationBits = CallFrame::Location::encode(index,
CallFrame::Location::CodeOriginIndex);

Minor nit: Usually, when we supply a tag to a function call, the tag is first
and the data is second.

> Source/JavaScriptCore/interpreter/CallFrame.h:1
> + /*

Please fix.

> Source/JavaScriptCore/interpreter/CallFrame.h:119
> +	       enum Decoration {

Maybe a word like "Type" or "LocationType" would be a little more specific.

> Source/JavaScriptCore/interpreter/CallFrame.h:122
> +		   InlinedFrame = (1 << 1),

To make this a comment about the location, how about calling this
"IsInlinedCode"?