[webkit-reviews] review denied: [Bug 18305] Border drawing incorrect when using both border-collapse: collapse and overflow: hidden on a table : [Attachment 203523] Patch

[bugzilla-daemon at webkit.org]

Dave Hyatt <hyatt at apple.com> has denied Robert Hogan <robert at webkit.org>'s
request for review:
Bug 18305: Border drawing incorrect when using both border-collapse: collapse
and overflow: hidden on a table
https://bugs.webkit.org/show_bug.cgi?id=18305

Attachment 203523: Patch
https://bugs.webkit.org/attachment.cgi?id=203523&action=review

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=203523&action=review


r-

> Source/WebCore/rendering/RenderTable.cpp:1363
> +    if (phase == PaintPhaseChildBlockBackgrounds) {
> +	   rect = borderBoxRectInRegion(region);
> +	   rect.setLocation(location + rect.location());
> +	   clipScrollBars(rect, relevancy);

This code doesn't make much sense to me. Isn't the clipScrollbars rectangle
going to clip scrollbars in the wrong place?