[webkit-reviews] review requested: [Bug 116534] [GStreamer] Adjust internal size on http source element when receiving data if necessary : [Attachment 203947] Adjust internal size when receiving data if needed

[bugzilla-daemon at webkit.org]

Andre Moreira Magalhaes <andrunko at gmail.com> has asked	for review:
Bug 116534: [GStreamer] Adjust internal size on http source element when
receiving data if necessary
https://bugs.webkit.org/show_bug.cgi?id=116534

Attachment 203947: Adjust internal size when receiving data if needed 
https://bugs.webkit.org/attachment.cgi?id=203947&action=review

------- Additional Comments from Andre Moreira Magalhaes <andrunko at gmail.com>
(In reply to comment #8)
> > > >
Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:1020
> > > > +    if (priv->size != 0 && priv->offset > priv->size) {
> > > 
> > > This is confusing offset and size are both unsigned so if offset == 0 it
will never be > size. This could probably just be 
> > > 
> > > if (priv->offset > priv->size)
> > > 
> > But IIRC, if priv->size == 0 (set in didReceiveResponse) we don't want/need
to update the internal size as didReceiveResponse will disable seek, etc on the
gst appsrc. No change here
> 
> You are right, I read the comparison wrongly. But still, you should do:
> 
> if (priv->size && priv->offset > priv->size)
> 
> or 
> 
> if (priv->size > 0 && priv->offset > priv->size)
> 
> to make the style bot happy.
hehe, done :).