[webkit-reviews] review granted: [Bug 117290] [CSSRegions] getBoundingClientRect wrong for inline content nodes : [Attachment 203935] Patch

[bugzilla-daemon at webkit.org]

Alexandru Chiculita <achicu at adobe.com> has granted Mihnea Ovidenie
<mihnea at adobe.com>'s request for review:
Bug 117290: [CSSRegions] getBoundingClientRect wrong for inline content nodes
https://bugs.webkit.org/show_bug.cgi?id=117290

Attachment 203935: Patch
https://bugs.webkit.org/attachment.cgi?id=203935&action=review

------- Additional Comments from Alexandru Chiculita <achicu at adobe.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=203935&action=review


Looks good.

> LayoutTests/fast/regions/flowed-inline-content-bounding-client-rect.html:2
> +

nit: I've usually been asked to make tests look like a standard html page with
head & body tags.

> Source/WebCore/rendering/RenderFlowThread.cpp:1157
> +    RenderRegion* region = mapFromFlowToRegion(transformState);
> +    if (region)

nit: You can combine these lines in one.

> Source/WebCore/rendering/RenderFlowThread.cpp:1158
> +	   static_cast<const
RenderObject*>(region)->mapLocalToContainer(region->containerForRepaint(),
transformState, mode, wasFixed);

nit: Mihai was right on the other bug. We need to fix this cast.