[webkit-reviews] review granted: [Bug 117288] ResourceLoader::resourceData() should not return a PassRefPtr : [Attachment 203924] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 117288: ResourceLoader::resourceData() should not return a PassRefPtr
https://bugs.webkit.org/show_bug.cgi?id=117288

Attachment 203924: Patch
https://bugs.webkit.org/attachment.cgi?id=203924&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=203924&action=review


> Source/WebCore/ChangeLog:10
> +	   Change ResourceLoader::resourceData() to return a raw pointer
> +	   instead of a PassRefPtr since we don't want to transfer the
> +	   ownership of the resource data. Also pass a raw pointer to

Definitely a good change.

> Source/WebCore/ChangeLog:14
> +	   CachedResource::data() so that the cached resource can decide
> +	   whether to take a reference of the data or not, for example,
> +	   CachedRawResource only takes a reference when buffering policy is
> +	   BufferData.

Not sure this change is as good, but it’s OK.