[webkit-reviews] review requested: [Bug 117265] Spatial Navigation should avoid unwanted calculation while deciding focus candidate. : [Attachment 203905] 117265.patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 5 22:58:35 PDT 2013


Abhijeet Kandalkar <kandalkar.abhijeet58 at gmail.com> has asked  for review:
Bug 117265: Spatial Navigation should avoid unwanted calculation while deciding
focus candidate.
https://bugs.webkit.org/show_bug.cgi?id=117265

Attachment 203905: 117265.patch 
https://bugs.webkit.org/attachment.cgi?id=203905&action=review

------- Additional Comments from Abhijeet Kandalkar
<kandalkar.abhijeet58 at gmail.com>
Spatial Navigation should consider only those nodes as candidate which are
exactly in the focus-direction.
e.g. If we are moving down then the nodes that are above CURRENT focused node
should be considered as invalid.
Added isValidCandidate() which checks whether node is exactly in the
focus-direction,if it is not it start iteration
with next node and avoid extra calculation.


More information about the webkit-reviews mailing list