[webkit-reviews] review granted: [Bug 117262] Disambiguate between CallFrame bytecodeOffset and codeOriginIndex : [Attachment 203897] corrected patch.

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Mark Lam <mark.lam at apple.com>'s
request for review:
Bug 117262: Disambiguate between CallFrame bytecodeOffset and codeOriginIndex
https://bugs.webkit.org/show_bug.cgi?id=117262

Attachment 203897: corrected patch. 
https://bugs.webkit.org/attachment.cgi?id=203897&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=203897&action=review


r=me

> Source/JavaScriptCore/interpreter/CallFrame.cpp:45
> +unsigned CallFrame::locationAsBytecodeOffset() const

This should ASSERT hasLocationAsBytecodeOffset().

> Source/JavaScriptCore/interpreter/CallFrame.cpp:51
> +void CallFrame::setLocationAsBytecodeOffset(unsigned offset)

This should ASSERT hasLocationAsBytecodeOffset() after the set -- or ASSERT
that offset is not a CodeOrigin handle.

> Source/JavaScriptCore/interpreter/CallFrameInlines.h:62
> +inline void CallFrame::setLocationAsBytecodeOffset(unsigned offset)

This should ASSERT hasLocationAsBytecodeOffset() after the set -- or ASSERT
that offset is not a CodeOrigin handle.