[webkit-reviews] review denied: [Bug 70117] Expose HTMLCanvasElement supportsContext : [Attachment 203895] Patch

[bugzilla-daemon at webkit.org]

Ruth Fong <ruthiecftg at gmail.com> has denied Ruth Fong <ruthiecftg at gmail.com>'s
request for review:
Bug 70117: Expose HTMLCanvasElement supportsContext
https://bugs.webkit.org/show_bug.cgi?id=70117

Attachment 203895: Patch
https://bugs.webkit.org/attachment.cgi?id=203895&action=review

------- Additional Comments from Ruth Fong <ruthiecftg at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=203895&action=review


This is WIP patch (I need to add and polish the tests for testing well-formed
and malformed attributes).

> LayoutTests/fast/canvas/webgl/canvas-supports-context.html:90
> +    } catch (e) {

This part needs to be revised and more test cases added. 

Sam, is there a better way to do this? I tried using shouldThrow and
shouldBeUndefined but was getting a ReferenceError saying it couldn't
reference/find my variables (i.e. canvas, etc.).