[webkit-reviews] review denied: [Bug 117256] [curl] Add implementation for HTTP PUT method : [Attachment 203852] stylefixed implementation

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has denied Peter Gal
<galpeter at inf.u-szeged.hu>'s request for review:
Bug 117256: [curl] Add implementation for HTTP PUT method
https://bugs.webkit.org/show_bug.cgi?id=117256

Attachment 203852: stylefixed implementation
https://bugs.webkit.org/attachment.cgi?id=203852&action=review

------- Additional Comments from Brent Fulgham <bfulgham at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=203852&action=review


Looks very good.  I had a couple of things I'd like you to cleanup before we
land.  Thanks!

> Source/WebCore/platform/network/curl/ResourceHandleManager.cpp:484
> + */

We don't usually add header comments like these. We prefer to have the
function/method name describe what the method does.

> Source/WebCore/platform/network/curl/ResourceHandleManager.cpp:556
> + */

Comment is unecessary

> Source/WebCore/platform/network/curl/ResourceHandleManager.cpp:574
> + */

Comment is unecessary

> Source/WebCore/platform/network/curl/ResourceHandleManager.cpp:586
> +    Vector<FormDataElement> elements =
job->firstRequest().httpBody()->elements();

I don't think this Vector is needed.