[webkit-reviews] review requested: [Bug 115647] [atk] Replace deprecated call to atk_document_get_locale() in DumpRenderTree : [Attachment 203873] patch reworked to remove GOwnPtr on textAttributes

[bugzilla-daemon at webkit.org]

Eduardo Lima Mitev <elima at igalia.com> has asked  for review:
Bug 115647: [atk] Replace deprecated call to atk_document_get_locale() in
DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=115647

Attachment 203873: patch reworked to remove GOwnPtr on textAttributes
https://bugs.webkit.org/attachment.cgi?id=203873&action=review

------- Additional Comments from Eduardo Lima Mitev <elima at igalia.com>
This new patch removes the GOwnPtr wrapper and use the AtkAttributeSet pointer
directly.

Following Mario's comment, I think we might want to consider specializing
GOwnPtr for AtkAttributeSet, but as part of a new story, and move on with this
patch.

The only other place where a GOwnPtr is used on an AtkAttributeSet is in
`Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:68`.