[webkit-reviews] review granted: [Bug 117252] SVG objects are misplaced when SVG root has transform. : [Attachment 203845] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Zalan Bujtas
<zalan at apple.com>'s request for review:
Bug 117252: SVG objects are misplaced when SVG root has transform.
https://bugs.webkit.org/show_bug.cgi?id=117252

Attachment 203845: Patch
https://bugs.webkit.org/attachment.cgi?id=203845&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=203845&action=review


r+ but please make a ref test.

> Source/WebCore/ChangeLog:3
> +	   SVG objects are misplaced when SVG root has transform.

The bug title should be updated to say "has a CSS transform"

> LayoutTests/ChangeLog:15
> +	   * fast/transforms/transform-svg-expected.txt: Added.
> +	   * fast/transforms/transform-svg.html: Added.

Wouldn't this be better as a ref test (e.g. compare translate(100px, 0) with
left: 100px.