[webkit-reviews] review granted: [Bug 117143] Make WTR use its own temporary directory for application cache : [Attachment 203791] proposed patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jun 5 10:05:31 PDT 2013
Alexey Proskuryakov <ap at webkit.org> has granted Csaba Osztrogonac
<ossy at webkit.org>'s request for review:
Bug 117143: Make WTR use its own temporary directory for application cache
https://bugs.webkit.org/show_bug.cgi?id=117143
Attachment 203791: proposed patch
https://bugs.webkit.org/attachment.cgi?id=203791&action=review
------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=203791&action=review
> Source/WebKit2/UIProcess/API/C/WKContextPrivate.h:62
> // FIXME: These functions are only effective if called before the Web
process is launched. But
> // we should really change these settings to be on WebPreferences and
changeable at runtime.
I would say that these functions are for WebKitTestRunner only, and would also
consider going WebKit1 way, and just providing a single override for all cache
files.
Perhaps there was a reason for fine-grained controls that I'm not aware of
though.
More information about the webkit-reviews
mailing list