[webkit-reviews] review granted: [Bug 117255] [WinCairo] Build failure. : [Attachment 203851] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 5 09:17:37 PDT 2013


Daniel Bates <dbates at webkit.org> has granted peavo at outlook.com's request for
review:
Bug 117255: [WinCairo] Build failure.
https://bugs.webkit.org/show_bug.cgi?id=117255

Attachment 203851: Patch
https://bugs.webkit.org/attachment.cgi?id=203851&action=review

------- Additional Comments from Daniel Bates <dbates at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=203851&action=review


This patch looks straightforward to me.

r=me

> Tools/ChangeLog:3
> +	   [WinCairo] Build failure.

Do we know when the build began failing? From briefly looking through SVN
history it looks like the WinCairo broken during the transition from VS2005 to
VS2010. Maybe a more appropriate bug title would be "Fix build-webkit to build
WinCairo under VS2010"?


More information about the webkit-reviews mailing list