[webkit-reviews] review granted: [Bug 117244] Use WEBKITOUTPUTDIR if WEBKIT_OUTPUTDIR is not present. : [Attachment 203799] Patch

[bugzilla-daemon at webkit.org]

Daniel Bates <dbates at webkit.org> has granted Raphael Kubo da Costa (rakuco,
Intel) <rakuco at webkit.org>'s request for review:
Bug 117244: Use WEBKITOUTPUTDIR if WEBKIT_OUTPUTDIR is not present.
https://bugs.webkit.org/show_bug.cgi?id=117244

Attachment 203799: Patch
https://bugs.webkit.org/attachment.cgi?id=203799&action=review

------- Additional Comments from Daniel Bates <dbates at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=203799&action=review


> Tools/Scripts/webkitdirs.pm:188
> +    $baseProductDir = $ENV{"WEBKITOUTPUTDIR"} if not $baseProductDir;

I suggest we file a bug to remove support for WEBKITOUTPUTDIR for GTK+ and EFL
and add a FIXME comment to the code that references the bug and explains that
we should remove this line once GTK+ and EFL builds have transitioned to
WEBKIT_OUTPUTDIR.