[webkit-reviews] review granted: [Bug 111066] svn-apply cannot apply patches which is generated by git to files that contain space characters in their path : [Attachment 203769] Patch

[bugzilla-daemon at webkit.org]

Daniel Bates <dbates at webkit.org> has granted Yuki Sekiguchi
<yuki.sekiguchi at access-company.com>'s request for review:
Bug 111066: svn-apply cannot apply patches which is generated by git to files
that contain space characters in their path
https://bugs.webkit.org/show_bug.cgi?id=111066

Attachment 203769: Patch
https://bugs.webkit.org/attachment.cgi?id=203769&action=review

------- Additional Comments from Daniel Bates <dbates at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=203769&action=review


> Tools/ChangeLog:8
> +	   If the path in diff start line has space characters,
parseGitDiffHeader() considered last non-space characters as file path.

As aforementioned in comment #25, I think a better way to phrase this sentence
would be:

Fixes an issue where parseGitDiffHeader() would extract the wrong substring of
the diff --git line as the target file path when the source file path contains
a space character.