[webkit-reviews] review granted: [Bug 111919] Coordinated Graphics: Unify messages related object's lifecycles into CoordinatedGraphicsState. : [Attachment 203777] Patch

[bugzilla-daemon at webkit.org]

Noam Rosenthal <noam at webkit.org> has granted  review:
Bug 111919: Coordinated Graphics: Unify messages related object's lifecycles
into CoordinatedGraphicsState.
https://bugs.webkit.org/show_bug.cgi?id=111919

Attachment 203777: Patch
https://bugs.webkit.org/attachment.cgi?id=203777&action=review

------- Additional Comments from Noam Rosenthal <noam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=203777&action=review


>>>
Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedImageBacking.cpp
:118
>>> +	 m_isDirty = false;
>> 
>> This seems unrelated
> 
> Because this patch does defers creating a handle of WebCoordinatedSurface to
sync time, we cannot check whether it is failed, so fallback logic was removed.

> 
> I think cleaning m_isDirty is necessary because it indicates ImageBacking
posts its update.

OK.