[webkit-reviews] review denied: [Bug 111919] Coordinated Graphics: Unify messages related object's lifecycles into CoordinatedGraphicsState. : [Attachment 203777] Patch

[bugzilla-daemon at webkit.org]

Noam Rosenthal <noam at webkit.org> has denied Gwang Yoon Hwang
<ryumiel at company100.net>'s request for review:
Bug 111919: Coordinated Graphics: Unify messages related object's lifecycles
into CoordinatedGraphicsState.
https://bugs.webkit.org/show_bug.cgi?id=111919

Attachment 203777: Patch
https://bugs.webkit.org/attachment.cgi?id=203777&action=review

------- Additional Comments from Noam Rosenthal <noam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=203777&action=review


Great! but has a couple of unrelated changes

>
Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedImageBacking.cpp
:118
> -    // If sending the message fails, try again in the next update.
> -    bool success = m_coordinator->updateImageBacking(id(), m_surface);
> -    m_isDirty = !success;
> +    m_coordinator->updateImageBacking(id(), m_surface);
> +    m_isDirty = false;

This seems unrelated

>
Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.
cpp:402
> +    size_t index = m_state.layersToCreate.find(layer->id());
> +    if (index != notFound) {
> +	   m_state.layersToCreate.remove(index);
> +	   return;
> +    }
> +
> +    m_state.layersToRemove.append(layer->id());

This seems unrelated as well