[webkit-reviews] review denied: [Bug 117198] [GTK] Forwarding headers not generated for incremental build : [Attachment 203699] Now with changelog

[bugzilla-daemon at webkit.org]

Carlos Garcia Campos <cgarcia at igalia.com> has denied Wojciech Bielawski
<w.bielawski at samsung.com>'s request for review:
Bug 117198: [GTK] Forwarding headers not generated for incremental build
https://bugs.webkit.org/show_bug.cgi?id=117198

Attachment 203699: Now with changelog
https://bugs.webkit.org/attachment.cgi?id=203699&action=review

------- Additional Comments from Carlos Garcia Campos <cgarcia at igalia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=203699&action=review


Patch looks good to me, could you please update the changelog entry to match
the bug? We have scripts that parse the changelog entries, so it's important to
make sure they are generated correctly. Use the prepare-ChangeLog script to
make sure.

> Tools/ChangeLog:3
> +	   [GTK] Generate forwarding headers if needed even for incremental
build.

This doesn't match the bug title, you should use the
Tools/Scripts/prepare-ChangeLog to generate the changelog entry.

> Tools/ChangeLog:4
> +	   https://bugs.webkit.org/show_bug.cgi?id=117198.

And this doesn't finish with a period