[webkit-reviews] review granted: [Bug 112429] Web Inspector: Timeline. Clear button doesn't clean Memory graph in Overview pane. : [Attachment 203767] patch

[bugzilla-daemon at webkit.org]

Noam Rosenthal <noam at webkit.org> has granted Roland Takacs
<rtakacs at inf.u-szeged.hu>'s request for review:
Bug 112429: Web Inspector: Timeline. Clear button doesn't clean Memory graph in
Overview pane.
https://bugs.webkit.org/show_bug.cgi?id=112429

Attachment 203767: patch
https://bugs.webkit.org/attachment.cgi?id=203767&action=review

------- Additional Comments from Noam Rosenthal <noam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=203767&action=review


> Source/WebCore/ChangeLog:8
> +	   There is too early return from TimelineMemoryOverview.update() when

There is an early return

> Source/WebCore/ChangeLog:9
> +	   record array is empty. Thats why if you clik onto the clear button,

click

> Source/WebCore/ChangeLog:13
> +	   I've moved this "return condition" after the canvas size definition
> +	   because we need to know the canvas size for refreshing.
> +	   I've overridden TimelineOverviewBase's reset function to clear

I've moved -> Moved
I've overridden -> Overridden