[webkit-reviews] review denied: [Bug 117221] Modify scripts to support VS2010 build environment : [Attachment 203750] patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has denied Roger Fong
<roger_fong at apple.com>'s request for review:
Bug 117221: Modify scripts to support VS2010 build environment
https://bugs.webkit.org/show_bug.cgi?id=117221

Attachment 203750: patch
https://bugs.webkit.org/attachment.cgi?id=203750&action=review

------- Additional Comments from Brent Fulgham <bfulgham at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=203750&action=review


Looks good, but I think we want to keep the WEBKIT_SOURCE environment setup.

> Scripts/webkitdirs.pm:-1583
> -	   $variablesToSet{WEBKIT_SOURCE} = windowsSourceSourceDir() unless
$ENV{WEBKIT_SOURCE};

I don't think you want to get rid of this one!

> Scripts/webkitdirs.pm:-1624
> -	   }

Ditto -- don't we need this?

> Scripts/webkitdirs.pm:-1669
> -    }

Getting rid of this stanza is good ....

> Scripts/webkitdirs.pm:-1673
> -    }

... but getting rid of this stanza is not.