[webkit-reviews] review requested: [Bug 116689] Regression(r145959) Convert <select> to new flex box causes strange positioning problems : [Attachment 203741] safer patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 4 16:54:30 PDT 2013


Roger Fong <roger_fong at apple.com> has asked  for review:
Bug 116689: Regression(r145959) Convert <select> to new flex box causes strange
positioning problems
https://bugs.webkit.org/show_bug.cgi?id=116689

Attachment 203741: safer patch
https://bugs.webkit.org/attachment.cgi?id=203741&action=review

------- Additional Comments from Roger Fong <roger_fong at apple.com>
This patch is safer. It moves clearLayoutOverflow back to layout() so that the
only time it's called at a different time is when finishdelayedscrolling is
called.
Thus clearLayoutOverflow will never get called earlier than its supposed to be.


The delayed logic is a little more spread out because of this but it's at least
still all in RenderBlock :).

In addition, I ran the failing test and it does not fail locally, which
apparently doesn't mean much to the bots, but it's something.


More information about the webkit-reviews mailing list