[webkit-reviews] review granted: [Bug 117212] [Windows] Revise Windows code in NRWT to properly distinguish between "win32" and "cygwin" behavior : [Attachment 203730] Patch

[bugzilla-daemon at webkit.org]

Dirk Pranke <dpranke at chromium.org> has granted Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 117212: [Windows] Revise Windows code in NRWT to properly distinguish
between "win32" and "cygwin" behavior
https://bugs.webkit.org/show_bug.cgi?id=117212

Attachment 203730: Patch
https://bugs.webkit.org/attachment.cgi?id=203730&action=review

------- Additional Comments from Dirk Pranke <dpranke at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=203730&action=review


> Tools/Scripts/webkitpy/common/system/crashlogs.py:39
> +	   self._results_directory = results_directory

I was suggesting you make one change or the other, and you came up with a weird
hybrid :). I would just pass results_directory into find_newest_log(), but this
is okay, too.