[webkit-reviews] review requested: [Bug 115610] Add Support for mspace element : [Attachment 203729] Patch V5 - ter

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 4 15:09:52 PDT 2013


Frédéric Wang <fred.wang at free.fr> has asked  for review:
Bug 115610: Add Support for mspace element
https://bugs.webkit.org/show_bug.cgi?id=115610

Attachment 203729: Patch V5 - ter
https://bugs.webkit.org/attachment.cgi?id=203729&action=review

------- Additional Comments from Frédéric Wang <fred.wang at free.fr>
> Perhaps you need to add the new file to the MathMLAllInOne.cpp file?

I doubt this is the problem. The new files are for the mspace element and are
in rendering/ while MathMLAllInOne does not contain any reference for other
elements (mfrac, mfenced, msqrt etc).

> It seems you also removed something that looks like a BOM from the beginning
of the file. I'm not sure if that's important or not...

That could well be the issue. I just refreshed the patch and will try again
without this modification. If that does not work I'll try the Python script
later.


More information about the webkit-reviews mailing list