[webkit-reviews] review granted: [Bug 117201] AX: WK2: accessibility position is calculated every time window frame is updated : [Attachment 203703] patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted chris fleizach
<cfleizach at apple.com>'s request for review:
Bug 117201: AX: WK2: accessibility position is calculated every time window
frame is updated
https://bugs.webkit.org/show_bug.cgi?id=117201

Attachment 203703: patch
https://bugs.webkit.org/attachment.cgi?id=203703&action=review

------- Additional Comments from Tim Horton <thorton at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=203703&action=review


>>> Source/WebKit2/UIProcess/API/mac/WKView.mm:460
>>> +	 if (WebCore::AXObjectCache::accessibilityEnabled())
>> 
>> does this really work in the UIProcess? how?
> 
> it just a static boolean, so we can use it to store whether we're enabled or
not and it's valid for the lifetime of the process using it

OK, separate values tracking the same thing in the same place, but not needing
to be kept in sync explicitly.