[webkit-reviews] review granted: [Bug 116959] [EFl][WK2] Sub menu items should be of EWK_SUBMENU_TYPE and not checkable : [Attachment 203190] patch

[bugzilla-daemon at webkit.org]

Gyuyoung Kim <gyuyoung.kim at samsung.com> has granted Michal Pakula vel Rutka
<m.pakula at samsung.com>'s request for review:
Bug 116959: [EFl][WK2] Sub menu items should be of EWK_SUBMENU_TYPE and not
checkable
https://bugs.webkit.org/show_bug.cgi?id=116959

Attachment 203190: patch
https://bugs.webkit.org/attachment.cgi?id=203190&action=review

------- Additional Comments from Gyuyoung Kim <gyuyoung.kim at samsung.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=203190&action=review


LGTM. This patch follows a policy of WK2 Context menu C APIs.

> Source/WebKit2/ChangeLog:10
> +	   This patch changes ewk context menu API to match WebKit behaviour,
by creating sub menus with

WebKit behaviour -> WebKit2 behaviour ? It looks WebKit1 has other behaviour
differ from port to port.

> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_context_menu.cpp:103
> +    Ewk_Context_Menu_Item* newItem3 =
ewk_context_menu_item_new_with_submenu(EWK_CONTEXT_MENU_ITEM_TAG_OTHER, "New
Custom Item 3", true, subMenu2);

Isn't it better to use other action ?