[webkit-reviews] review granted: [Bug 117098] [Windows] NRWT is not putting crash logs in proper place : [Attachment 203635] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 117098: [Windows] NRWT is not putting crash logs in proper place
https://bugs.webkit.org/show_bug.cgi?id=117098

Attachment 203635: Patch
https://bugs.webkit.org/attachment.cgi?id=203635&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=203635&action=review


> Tools/Scripts/webkitpy/common/system/crashlogs.py:35
> +    PID_LINE_REGEX = re.compile('\s+Global\s+PID:\s+\[(?P<pid>\d+)\]')

Use r'~'.

> Tools/Scripts/webkitpy/common/system/crashlogs.py:96
> +		       f = self._host.filesystem.read_text_file(path, 'ignore')

> +		       match = self.PID_LINE_REGEX.search(f)
> +		       if match is None:
> +			   continue
> +		       if int(match.group('pid')) == pid:
> +			   return errors + f

Please don't use one-letter variable like f.  I'd call this variable log_file.