[webkit-reviews] review denied: [Bug 115647] [atk] Replace deprecated call to atk_document_get_locale() in DumpRenderTree : [Attachment 203613] updated patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has denied Eduardo Lima Mitev
<elima at igalia.com>'s request for review:
Bug 115647: [atk] Replace deprecated call to atk_document_get_locale() in
DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=115647

Attachment 203613: updated patch
https://bugs.webkit.org/attachment.cgi?id=203613&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=203613&action=review


> Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp:820
> +	   atk_attribute_set_free(textAttributes.get());

I think it's a mistake to use a GOwnPtr and to manually free the same thing.
Either make GOwnPtr specialization for AtkTextAttributes (if one doesn't exist
already) or free it manually.