[webkit-reviews] review denied: [Bug 117146] Add omitted NDEBUG option in InlineBox : [Attachment 203586] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has denied Kangil Han
<kangil.han at samsung.com>'s request for review:
Bug 117146: Add omitted NDEBUG option in InlineBox
https://bugs.webkit.org/show_bug.cgi?id=117146

Attachment 203586: Patch
https://bugs.webkit.org/attachment.cgi?id=203586&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
You are right that the code is not quite correct - NDEBUG and ASSERT_DISABLED
usually go hand in hand, but sometimes people do use release builds with
assertions enabled, and this code will fail to build in this configuration.

A better way to fix this is to change NDEBUG #ifs to ASSERT_DISABLED ones
elsewhere in this file.