[webkit-reviews] review granted: [Bug 116861] Remove XMLMIMETypeRegExp : [Attachment 203040] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jun 3 10:28:37 PDT 2013


Alexey Proskuryakov <ap at webkit.org> has granted Zan Dobersek
<zandobersek at gmail.com>'s request for review:
Bug 116861: Remove XMLMIMETypeRegExp
https://bugs.webkit.org/show_bug.cgi?id=116861

Attachment 203040: Patch
https://bugs.webkit.org/attachment.cgi?id=203040&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=203040&action=review


> Source/WebCore/dom/DOMImplementation.cpp:351
> +    size_t slashPosition = mimeType.find('/');

If this was performance sensitive code, it would be better to iterate once,
checking for '/' restrictions where "i != slashPosition" check currently is.


More information about the webkit-reviews mailing list