[webkit-reviews] review granted: [Bug 117132] onended Event is not received in AudioBufferSourceNode and OscillatorNode : [Attachment 203564] Patch

[bugzilla-daemon at webkit.org]

Christophe Dumez <dchris at gmail.com> has granted Praveen Jadhav
<praveen.j at samsung.com>'s request for review:
Bug 117132: onended Event is not received in AudioBufferSourceNode and
OscillatorNode
https://bugs.webkit.org/show_bug.cgi?id=117132

Attachment 203564: Patch
https://bugs.webkit.org/attachment.cgi?id=203564&action=review

------- Additional Comments from Christophe Dumez <dchris at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=203564&action=review


Looks good, r=me. But please improve the Changelogs before landing.

> Source/WebCore/ChangeLog:3
> +	   onended Event is not received in AudioBufferSourceNode and
OscillatorNode.

'onevent' event...

> Source/WebCore/ChangeLog:8
> +	   PassRefPtr is set to null after usage in
setAttributeEventListener().

This would be better IMHO: "The listener argument is a PassRefPtr which becomes
NULL after the call to setAttributeEventListener() in setOnended(). This causes
the m_hasEndedListener boolean to be incorrectly initialized. This patch
reverses the two statements so that the m_hasEndedListener is updated before
the call to setAttributeEventListener()."

> Source/WebCore/ChangeLog:11
> +	   No new tests. Present layout tests will cover all the scenarios.

No new tests, already covered by existing tests.

> LayoutTests/ChangeLog:8
> +	   Re-enabling failed webaudio tests due to 'onended' event not being

"Unskip webaudio test cases that were failing due to the 'onended' event not
being fired."