[webkit-reviews] review requested: [Bug 115406] [GTK] Use drawErrorUnderline() instead of Pango API for highlighting misspelled words : [Attachment 203567] updated patch including new baseline PNGs

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jun 3 02:54:41 PDT 2013


Eduardo Lima Mitev <elima at igalia.com> has asked  for review:
Bug 115406: [GTK] Use drawErrorUnderline() instead of Pango API for
highlighting misspelled words
https://bugs.webkit.org/show_bug.cgi?id=115406

Attachment 203567: updated patch including new baseline PNGs
https://bugs.webkit.org/attachment.cgi?id=203567&action=review

------- Additional Comments from Eduardo Lima Mitev <elima at igalia.com>
This patch adds 3 new baseline PNG images for spell checking tests that were
not passing pixel hash comparison.

It also wraps drawErrorUnderline() logic with new filled cairo path.


More information about the webkit-reviews mailing list