[webkit-reviews] review granted: [Bug 114862] [EFL]<select> element's text is clipped when a height is specified along with CSS line-height. : [Attachment 203561] Patch

[bugzilla-daemon at webkit.org]

Gyuyoung Kim <gyuyoung.kim at samsung.com> has granted Rashmi Kulakarni
<rashmi.vijay at samsung.com>'s request for review:
Bug 114862: [EFL]<select> element's text is clipped when a height is specified
along with CSS line-height.
https://bugs.webkit.org/show_bug.cgi?id=114862

Attachment 203561: Patch
https://bugs.webkit.org/attachment.cgi?id=203561&action=review

------- Additional Comments from Gyuyoung Kim <gyuyoung.kim at samsung.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=203561&action=review


LGTM.

> Source/WebCore/platform/efl/RenderThemeEfl.cpp:869
> +    // Height is locked to auto if height is not specified

Generally, we have used . at the end of comment.

> Source/WebCore/platform/efl/RenderThemeEfl.cpp:872
> +    // The <select> box must be at least 12px high for the button to render
the text inside the box without clipping

ditto.

> Source/WebCore/platform/efl/RenderThemeEfl.cpp:875
> +    // Calculate min-height of the <select> element

ditto.