[webkit-reviews] review granted: [Bug 116814] Webkit crashes while loading content from Application Cache : [Attachment 203552] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Charles Wei
<charles.wei at torchmobile.com.cn>'s request for review:
Bug 116814: Webkit crashes while loading  content from Application Cache
https://bugs.webkit.org/show_bug.cgi?id=116814

Attachment 203552: Patch
https://bugs.webkit.org/attachment.cgi?id=203552&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
Should we fix this bug in ApplicationCacheHost::maybeLoadFallbackForError
instead? It can tell if the resource is the main resource. I think we could
just eliminate maybeLoadFallbackForMainError or make it a private function.
Seems that would be more elegant. Naturally we’d still delete the function call
from DocumentLoader::mainReceivedError, but we’d leave ResourceLoader::didFail
alone.

What do you think?

r=me to do this fix, but I think my refinement could make the division of
responsibilities between ResourceLoader and ApplicationCacheHost better.