[webkit-reviews] review granted: [Bug 117112] REGRESSION (r130783): Going "back" to a cached page from a page with a main resource error breaks scrolling, amongst other issues : [Attachment 203543] Patch v2 - Landable if tests pass

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Brady Eidson
<beidson at apple.com>'s request for review:
Bug 117112: REGRESSION (r130783): Going "back" to a cached page from a page
with a main resource error breaks scrolling, amongst other issues
https://bugs.webkit.org/show_bug.cgi?id=117112

Attachment 203543: Patch v2 - Landable if tests pass
https://bugs.webkit.org/attachment.cgi?id=203543&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=203543&action=review


r=me

>
LayoutTests/http/tests/loading/unfinished-load-back-to-cached-page-callbacks-ex
pected.txt:26
> +This test makes sure that going back to a cached page from a page that is
still loading produces the correct frame load callbacks. It is only useful
inside of WebKitTestRunner.

Would be helpful to have criteria for passing explained. How will we know if
any change in the long list of callbacks above means a horrible failure?