[webkit-reviews] review granted: [Bug 117116] [WK2][CoordinatedGraphics]: Use a properly initialized WebPage when creating a PageClient : [Attachment 203509] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Sergio Correia
<sergio.correia at openbossa.org>'s request for review:
Bug 117116: [WK2][CoordinatedGraphics]: Use a properly initialized WebPage when
creating a PageClient
https://bugs.webkit.org/show_bug.cgi?id=117116

Attachment 203509: Patch
https://bugs.webkit.org/attachment.cgi?id=203509&action=review

------- Additional Comments from Tim Horton <thorton at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=203509&action=review


> Source/WebKit2/ChangeLog:42
> +	   Here's the relevant valgrind trace for reference:
> +
> +	   Conditional jump or move depends on uninitialised value(s)
> +	       at 0x65A35A4:
WebKit::WebPageProxy::WebPageProxy(WebKit::PageClient*,
> +			     WTF::PassRefPtr<WebKit::WebProcessProxy>,
> +			     WebKit::WebPageGroup*, unsigned long)
(WebPageProxy.cpp:322)
> +	       by 0x65A2BA2: WebKit::WebPageProxy::create(WebKit::PageClient*,
> +			     WTF::PassRefPtr<WebKit::WebProcessProxy>,
> +			     WebKit::WebPageGroup*, unsigned long)
(WebPageProxy.cpp:233)
> +	       by 0x65E94BB:
WebKit::WebProcessProxy::createWebPage(WebKit::PageClient*,
> +			     WebKit::WebContext*, WebKit::WebPageGroup*)
> +			     (WebProcessProxy.cpp:172)
> +	       by 0x6570957:
WebKit::WebContext::createWebPage(WebKit::PageClient*,
> +			     WebKit::WebPageGroup*, WebKit::WebPageProxy*)
> +			     (WebContext.cpp:735)
> +	       by 0x67673E3: WebKit::WebView::WebView(WebKit::WebContext*,
> +			     WebKit::WebPageGroup*) (WebView.cpp:52)
> +	       by 0x6775F18:
WebKit::WebViewEfl::WebViewEfl(WebKit::WebContext*,
> +			     WebKit::WebPageGroup*) (WebViewEfl.cpp:54)
> +	       by 0x6775EB4: WebKit::WebView::create(WebKit::WebContext*,
> +			     WebKit::WebPageGroup*) (WebViewEfl.cpp:49)
> +	       by 0x673E13D: WKViewCreate (WKView.cpp:33)
> +	       by 0x6763ECE: EWKViewCreate (ewk_view.cpp:92)

This is a bit excessive for the changelog, I think, but it's fine.