[webkit-reviews] review granted: [Bug 117116] [WK2][CG]: Use a properly initialized WebPage when creating a PageClient : [Attachment 203501] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Jun 1 23:40:23 PDT 2013


Darin Adler <darin at apple.com> has granted Sergio Correia
<sergio.correia at openbossa.org>'s request for review:
Bug 117116: [WK2][CG]: Use a properly initialized WebPage when creating a
PageClient
https://bugs.webkit.org/show_bug.cgi?id=117116

Attachment 203501: Patch
https://bugs.webkit.org/attachment.cgi?id=203501&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=203501&action=review


> Source/WebKit2/UIProcess/CoordinatedGraphics/WebView.cpp:53
> +    m_page = context->createWebPage(this, pageGroup);

Needs a comment so someone doesn’t just move it back. Such as:

    // Need to call createWebPage after other data members, specifically
m_visible, are initialized.


More information about the webkit-reviews mailing list