[webkit-reviews] review granted: [Bug 117104] Move Node::hasID() and hasClass() to Element. : [Attachment 203481] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Jun 1 02:13:41 PDT 2013


Ryosuke Niwa <rniwa at webkit.org> has granted Andreas Kling <akling at apple.com>'s
request for review:
Bug 117104: Move Node::hasID() and hasClass() to Element.
https://bugs.webkit.org/show_bug.cgi?id=117104

Attachment 203481: Patch
https://bugs.webkit.org/attachment.cgi?id=203481&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=203481&action=review


> Source/WebCore/dom/LiveNodeList.cpp:114
> +	   if (!node->isElementNode())
> +	       continue;

Only ChildNodeList contains non-element item so maybe we want to check that
condition outside the loop instead.
We don't need to do this in this patch though.

> Source/WebCore/rendering/RenderLayer.cpp:283
> +    if (Element* element = renderer()->node() &&
renderer()->node()->isElementNode() ? toElement(renderer()->node()) : 0) {

Looks like we almost want renderer()->element().


More information about the webkit-reviews mailing list