[webkit-reviews] review denied: [Bug 117405] [EFL]Background Style of element not visible because of default theme style : [Attachment 207386] Patch

[bugzilla-daemon at webkit.org]

Gyuyoung Kim <gyuyoung.kim at samsung.com> has denied Santosh Mahto
<santosh.ma at samsung.com>'s request for review:
Bug 117405: [EFL]Background Style of element not visible because of  default
theme style
https://bugs.webkit.org/show_bug.cgi?id=117405

Attachment 207386: Patch
https://bugs.webkit.org/attachment.cgi?id=207386&action=review

------- Additional Comments from Gyuyoung Kim <gyuyoung.kim at samsung.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=207386&action=review


> Source/WebCore/ChangeLog:3
> +	   [EFL]Background Style of element not visible because of  default
theme style

Nit: [EFL]Background => [EFL] Background ? , of  default theme -> of default
theme ?

> Source/WebCore/ChangeLog:7
> +

Missing patch description.

> Source/WebCore/platform/efl/RenderThemeEfl.cpp:380
> +	   edje_object_signal_emit(entry->edje(), "bg_styled", "");

I think it would be better to add new function to emit new signal as media
button behavior.

Look at RenderThemeEfl::emitMediaButtonSignal().