[webkit-reviews] review granted: [Bug 117715] Reduce CSSProperty's StylePropertyMetadata memory footprint by half when used inside a ImmutableStylePropertySet. : [Attachment 207863] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 31 18:57:45 PDT 2013


Andreas Kling <akling at apple.com> has granted Alexis Menard (darktears)
<alexis at webkit.org>'s request for review:
Bug 117715: Reduce CSSProperty's StylePropertyMetadata memory footprint by half
when used inside a ImmutableStylePropertySet.
https://bugs.webkit.org/show_bug.cgi?id=117715

Attachment 207863: Patch
https://bugs.webkit.org/attachment.cgi?id=207863&action=review

------- Additional Comments from Andreas Kling <akling at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=207863&action=review


This patch needs a "Reviewed by" line.

> Source/WebCore/ChangeLog:10
> +	  
-------------------------------------------------------------------------------
-----------
> +	   | m_propertyID : 14 | m_shorthandID : 14 | m_important : 1|
m_implicit : 1| m_inherited:1|
> +	  
-------------------------------------------------------------------------------
-----------

Seems like these boxes would look better if vertical. :)

> Source/WebCore/ChangeLog:39
> +	  
-------------------------------------------------------------------------------
-----------------------
> +	   | m_propertyID : 10 (up to 1024 properties)| m_isSetFromShorthand :
1 | m_indexInShorthandsVector : 2|...
> +	  
-------------------------------------------------------------------------------
-----------------------

^


More information about the webkit-reviews mailing list